Fix timeit commands with backticks after command name#2415
Merged
Conversation
wookie184
added
a: backend
shtlrs
approved these changes
Feb 25, 2023
Contributor
shtlrs
left a comment
shtlrs
left a comment
There was a problem hiding this comment.
Didn't test this, but it doesn't look like the changes will break anything.
Other than that, LGTM !
brodycritchlow
approved these changes
Feb 26, 2023
Contributor
brodycritchlow
left a comment
brodycritchlow
left a comment
There was a problem hiding this comment.
Looks fine to me, don't see anything that could break.
Ibrahim2750mi
approved these changes
Feb 26, 2023
ChrisLovering
approved these changes
Feb 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In theory the list of allowed commands shouldn't be necessary, but I'd prefer to keep it to make the functionality more robust.